[editable-layers] Real double-click used to finish drawing#225
Merged
felixpalmer merged 3 commits intovisgl:masterfrom Nov 3, 2025
Merged
[editable-layers] Real double-click used to finish drawing#225felixpalmer merged 3 commits intovisgl:masterfrom
felixpalmer merged 3 commits intovisgl:masterfrom
Conversation
8 tasks
Contributor
|
I raised a duplicate by mistake, but thought it's was worth adding this as a question here so it doesn't get lost. I see that the connected PR updates DrawLineStringMode and DrawPolygonMode modes. Are there other modes which need fixing, such as MeasureDistanceMode? |
|
I'm having this issue as well, and hoping this fix can make it into the next minor / patch release. |
felixpalmer
approved these changes
Nov 3, 2025
felixpalmer
reviewed
Nov 3, 2025
ibgreen
pushed a commit
that referenced
this pull request
Nov 4, 2025
ibgreen
added a commit
that referenced
this pull request
Nov 4, 2025
* Add collapsed chain visibility tests and fix marker style typing * Improve DAG chain collapsing controls * Adjust collapsed chain markers * Add logging for collapsed chain interactions * Integrate DAG chain collapsing into graph viewer * Fix DAG chain toggles and highlight collapsed markers * Fix chain marker source resolution * Draw chain outlines using bounding boxes * Round chain outlines and color collapsed boxes red * feat(graph-layers): Add zod graph stylesheet schema dependencies (#333) * Enable Docusaurus v4 future flags (#338) * feat(experimental): add pan and zoom widget (#341) * Generate graph style JSON schema during build (#342) * docs: align graph styling guides and examples with stylesheet API (#340) * [editable-layers] Real double-click used to finish drawing (#225) * fix(graph-layers): restore dag arrow decorator color property (#343) * chore: CI run tests on commits in master (#344) * docs: consolidate graph stylesheet reference (#345) * wip --------- Co-authored-by: mwilniewiec <33090843+mwilniewiec@users.noreply.github.com> Co-authored-by: felixpalmer <felixpalmer@gmail.com>
8 tasks
|
what release is this fix being included in? |
Contributor
Author
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix for:
#226
Drawing of Polygon and LineString can now be finished using a normal double click.
I didn't fix "Polygon 90 degrees" behavior. I tried but I had some issues and probably its author or someone could take a look in a separate commit.
Before this change drawing was finished by "Enter" key or by "slow double click" which wasn't recognized as a normal "double click".
This was a regress to old nebula.gl and older deck.gl that I was using earlier and double click worked normally.